feat(mobile): native sync #18033
feat(mobile): native sync #18033
Conversation
shenlong-tanwen
force-pushed
the
feat/sqlite-native-sync
branch
2 times, most recently
from
adae03c to
e99f4ff
Compare
shenlong-tanwen
force-pushed
the
feat/sqlite-native-sync
branch
from
e99f4ff to
c0acd86
Compare
github-actions
bot
added
documentation
alextran1502
force-pushed
the
feat/sqlite-native-sync
branch
from
0424d32 to
3360883
Compare
shenlong-tanwen
force-pushed
the
feat/sqlite-native-sync
branch
from
3360883 to
09e5503
Compare
| var updatedArr: Set<WrapperAsset> = [] | ||
| var deletedArr: Set<String> = [] |
There was a problem hiding this comment.
What would happen if an asset is updated and then later deleted before this runs? Would the changes only show the deletion or would it end up in both lists?
There was a problem hiding this comment.
It only shows up as deleted from my limited testing. But we need to note these during our full testing of the implementation because the PhotoKit API is extremely quirky
| let deleted = details.deletedLocalIdentifiers | ||
|
|
||
| let options = PHFetchOptions() | ||
| options.includeHiddenAssets = false |
There was a problem hiding this comment.
If an asset started as not hidden and became hidden later, would this mean that immich would ignore this and later changes? Is that intentional?
There was a problem hiding this comment.
We do not handle hidden assets yet and ignoring them is okay for the time being. And, I don't think we need a PHFetchOption in the first place. I'll update the method call and pass nil for the options
| createdAt: createdAt, | ||
| updatedAt: updatedAt, | ||
| durationInSeconds: durationInSeconds, | ||
| albumIds: self._getAlbumIds(forAsset: asset) |
There was a problem hiding this comment.
You only need to do this for updated assets, not for inserted, right?
There was a problem hiding this comment.
We would also need this for inserted assets as well. If an asset was inserted after our last sync and also got added to multiple albums before we get to sync the changes, we need the albumIds to link it during our sync
There was a problem hiding this comment.
True, I guess I meant assets that were inserted but not updated, because we already know they're not in any albums (or they would be updated too).
mobile/android/app/src/main/kotlin/app/alextran/immich/platform/MediaManager.kt
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @RequiresApi(Build.VERSION_CODES.Q) | ||
| fun shouldFullSync(callback: (Result<Boolean>) -> Unit) { |
There was a problem hiding this comment.
I marked the methods as asynchronous in the messages template which generates the methods in the native side with a callback expecting the native methods to be asynchronous. However, none of our methods are asynchronous and removing the @async annotation actually makes the native API a lot more simpler. Will remove the async annotation and update the native methods to be synchronous
shenlong-tanwen
force-pushed
the
feat/sqlite-native-sync
branch
from
d583c07 to
4a9b8c2
Compare
shenlong-tanwen
force-pushed
the
feat/sqlite-native-sync
branch
from
4a9b8c2 to
30fc632
Compare
|
Superseded by #18428 |
No description provided.