-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat: support recognize apple spatial media #18055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support recognize apple spatial media #18055
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to add the translation here. Adding it to en.json is the only requirement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
1e74f74 to
0fd9b77
Compare
0fd9b77 to
c903e19
Compare
|
I think |
Implement enum, add create safe migration, if projection type have unexpected values |
zackpollard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some errors in the build with the metadata service not using the new enum type.
|
Hey, I am going to close this for now due to it being stale for quite a while. If you do get time to fix this please feel free to make a new PR or comment to have this one re-opened 🙂 |
Implement feature request #11564
Description
This is the first step towards full support for viewing spatial photos and videos in VR. I’ve added EXIF tag analysis to detect Apple Spatial Video. Instead of adding new columns to the EXIF table, I placed this information in the projectionType field—semantically, it seemed like the closest match. If you have ideas on how to improve this, I’d be happy to hear them.
I also added a 3D icon on the frontend if projectionType starts with SPATIAL, so that this logic can be extended in the future to support other 3D media formats.
How Has This Been Tested?
You can upload apple heic spatial photo and video and check exif information about it.
Screenshots (if appropriate)
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)