fix(server): use actual total in search pagination #18075
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the response of
/api/search/metadataincluded bothtotalandcountfields which were simply duplicates of one another and reflected the number of items in the current results page only, with nothing to indicate the total number of matched results.This PR changes the
totalto actually reflect the total number of results that can be obtained after requesting all the pages.How Has This Been Tested?
Tested manually by running Immich locally, adding some images to the library, and running some requests to
/api/search/metadata. For example, a request with{ "page": 1, "size": 4 }returns:{ "albums": { "total": 0, "count": 0, "items": [], "facets": [] }, "assets": { "total": 17, "count": 4, "items": [ /* ... */ ], "facets": [], "nextPage": "2" } }API Changes
The
totalfield in/api/search/metadataand/api/search/smartresults is no longer equivalent tocount.Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)