chore(web): migrate CircleIconButton to @immich/ui IconButton #18486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Deploying preview environment to https://pr-18486.preview.internal.immich.cloud/ |
bwees
force-pushed
the
chore/migrate-circle-icon-button
branch
from
9e6087f to
a758ca7
Compare
Member
|
A couple of issues
@jrasm91 We probably need an option to force dark or light for these buttons for correct behavior in some views that always stay dark, thoughts? |
Member
|
I guess we could add a theme prop that's light or dark and then:
|
bwees
force-pushed
the
chore/migrate-circle-icon-button
branch
2 times, most recently
from
c4ef70a to
4bd468a
Compare
Member
|
Hi Brandon, can you help resolve the merge conflict and then ping me? I will run another round of tests and get it in |
bwees
force-pushed
the
chore/migrate-circle-icon-button
branch
from
11dd3cc to
22e9d8e
Compare
bwees
requested review from
alextran1502 and
danieldietzler
and removed request for
alextran1502
danieldietzler
approved these changes
May 31, 2025
jrasm91
approved these changes
May 31, 2025
bwees
force-pushed
the
chore/migrate-circle-icon-button
branch
from
e042fa5 to
0285bc8
Compare
Member
|
A couple more
- The back button in asset-viewer also needs to be forced dark
Those are the two places I noticed. Please turn to light mode and check other pages as well. Thank you |
bwees
force-pushed
the
chore/migrate-circle-icon-button
branch
from
8f1c378 to
ba8a2ad
Compare
alextran1502
approved these changes
Jun 2, 2025
savely-krasovsky
pushed a commit
to savely-krasovsky/immich
that referenced
this pull request
Jun 8, 2025
…-app#18486) * remove import and referenced file * first pass at replacing all CircleIconButtons * fix linting issues * fix combobox formatting issues * fix button context menu coloring * remove circle icon button from search history box * use theme switcher from UI lib * dark mode force the asset viewer icons * fix forced dark mode icons * dark mode memory viewer icons * fix: back button in memory viewer --------- Co-authored-by: Alex <alex.tran1502@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces
CircleIconButtonwithIconButtonfrom@immich/ui.How Has This Been Tested?
This should definitely be checked over by multiple people to verify all buttons look correct. I did my best to find all buttons and verify they looked correct but there were some that I could not get to show.
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)