Conversation
Contributor
|
📖 Preview of ui.immich.app deployed to ui.pr-578.dev.immich.app |
jrasm91
reviewed
Feb 10, 2026
Member
jrasm91
left a comment
jrasm91
left a comment
There was a problem hiding this comment.
Would it be better to default it to navigator.language in the component itself?
Collaborator
Author
|
Hmm not sure. If the date picker were only used inside this library I’d say yes, but in Immich Web we should always pass the app locale |
Member
|
Could we add a state/manager for locale and we just set it once in immich-web? Like |
Collaborator
Author
|
Yep good idea, I've added that 👍 |
jrasm91
approved these changes
Feb 10, 2026
This was referenced Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds required
localeprop toDatePickerfor calendar and date format localization. It maintains theen-USdefault when undefined.