Remove snapshot .rs files #1300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we already track expected snapshot results in the .snap files
fw-immunant
force-pushed
the
fw/remove-snapshot-rs
branch
from
f00e78d to
38dc591
Compare
kkysen
reviewed
Jul 24, 2025
kkysen
added a commit
that referenced
this pull request
Jul 26, 2025
This tells GitHub and other tools to treat these snapshots as Rust files, which will allow us to keep syntax highlighting (including in diffs) after removing the `*.rs` intermediaries in #1300.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are outputs of snapshot testing, and are redundant with their corresponding
.snapfiles; tracking them is just clutter.