Revert "transpile: make --translate-{const,fn}-macros conservative the default for the CLI, too"
#1313
Conversation
|
Making PRs into branches other than master always confuses me. It means that reviewing requires considering the diff of the PR and the diff between the PR's destination and master. |
|
Shouldn't we revert the whole PR, not just one commit? Based on the CI run it looks like we have actual breakage that we should have fixed before merging the |
There was a problem hiding this comment.
Shouldn't we revert the whole PR, not just one commit? Based on the CI run it looks like we have actual breakage that we should have fixed before merging the
--translate-const-macroschanges; the particular commit here still looks correct to me in context.
The breakage is fundamentally from an earlier commit in the PR, but it's less churn for me to just revert this one, fix it, and then un-revert it. Can I merge this PR now? Might not be ideal, but it should just get things done quickly.
|
I'm going to merge this so CI stops being broken. |
This reverts commit 6c689e1.
This broke CI (
c2rust-testsuite), which wasn't caught because CI wasn't run on PRs not directly intomaster.c2rust-testsuiteon all PRs, not just those intomaster#1312 fixes this.