transpile: some docs/refactoring improvements made while fixing SrcLoc sorting
#1401
+127
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` to help debugging
… to many conflicts
fw-immunant
approved these changes
Oct 8, 2025
kkysen
commented
Oct 8, 2025
There was a problem hiding this comment.
LGTM in general, though I prefer the
syn::*glob import to the alternative here.
In general, I prefer not to use global glob imports, but here, especially, it kept causing conflicts with other imports and auto importing, and glob imports also make it difficult when reviewing to know where things are coming from.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are various improvements to docs, refactorings, etc. I made while working on and debugging #1400.