Skip to content

Conversation

@rishav-jha-mech
Copy link
Contributor

Fixed the text overflow issue in small devices.

Now the website is completely responsive !

@jdeniau
Copy link
Member

jdeniau commented Nov 21, 2021

Hi @rishav-jha-mech

If I apply your change, I got the following great content

image

😬

Can you tell me more about what you are trying to fix here ?

Thanks

@jdeniau jdeniau added the awaiting-response Awaiting response from creator. Can't fix without it. label Nov 21, 2021
@rishav-jha-mech
Copy link
Contributor Author

Im sorry 😥 actually i didn't go through the whole website i just saw the problem with the landing page.

Earlier in smaller devices (device width< 425px) the website would look like

Documentation latest@main — Immutable js - Google Chrome 22-11-2021 08_25_41

And after the fix it looks like

Documentation latest@main — Immutable js - Google Chrome 22-11-2021 08_26_14

The docs page was already responsive, but because of my first commit docs page got messed up (i did not see that page), however that is completely fixed in the latest commit and now the docs page looks like this.

Documentation latest@main — Immutable js - Google Chrome 22-11-2021 08_23_14

@jdeniau
Copy link
Member

jdeniau commented Nov 22, 2021

OK great! I focused on the doc page only without testing the home page.
Thank you for your PR!

@jdeniau jdeniau merged commit de19537 into immutable-js:main Dec 13, 2021
@jdeniau
Copy link
Member

jdeniau commented Dec 13, 2021

Thanks @rishav-jha-mech

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-response Awaiting response from creator. Can't fix without it. documentation enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants