This repository was archived by the owner on Jan 6, 2026. It is now read-only.
[DX-1703] Updated error handling#17
Merged
Merged
Conversation
PascalCross
requested review from
Nathan-Ballantyne,
phil-immutable and
suluvai
phil-immutable
approved these changes
Feb 3, 2023
Contributor
phil-immutable
left a comment
phil-immutable
left a comment
There was a problem hiding this comment.
Both demos work locally and can confirm this fixes the insecure URL error logged to console.
Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove potential error spam when attempting to fetch assets from unsecure connections.
Why the changes
Improves demo and logging quality.
Things worth calling out
Updated AssetListObject to only fetch links using https.
Added extra notes in ReadMe to remove warning spam from unsupported characters in asset names, this is due to text mesh pro throwing warnings when fonts do not contain certain characters, and can be disabled in a scriptable object.