chore(checkout): Additional overrides to facilitate the Immutable dev env#2607
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit f178666.
☁️ Nx Cloud last updated this comment at |
keithbro-imx
changed the title
keithbro-imx
commented
Apr 29, 2025
|
|
||
| return { balances }; | ||
| return balanceResults.reduce((acc, resp) => { | ||
| if (resp.status !== 'fulfilled' || resp.value.balance === 0n) return acc; |
Contributor
Author
There was a problem hiding this comment.
The change here is to filter out any zero balances. When fetching balances from the RPC it returns all tokens, even zero balance ones. So we need to filter these out to maintain the same behaviour as when we use blockscout.
keithbro-imx
commented
Apr 29, 2025
| this.publishableKey = config.publishableKey ?? '<no-publishable-key>'; | ||
|
|
||
| this.networkMap = networkMap(this.isProduction, this.isDevelopment); | ||
| this.networkMap = config.overrides?.networkMap ?? networkMap(this.isProduction, this.isDevelopment); |
Contributor
Author
There was a problem hiding this comment.
These changes are mostly about reading from the overrides
keithbro-imx
commented
Apr 29, 2025
| @@ -1,10 +1,13 @@ | |||
| import { Passport } from "@imtbl/passport"; | |||
| import { Environment } from "@imtbl/config"; | |||
| import * as x from "@imtbl/x-client"; | |||
allan-almeida-imtbl
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allows overrides to be passed to the checkout constructor so that it can be used in envs other than sandbox and prod.
Detail and impact of the change
Added
Changed
Deprecated
Removed
Fixed
Security
Anything else worth calling out?