Skip to content

feat(audience): scaffold @imtbl/audience-sdk package#2825

Merged
ImmutableJeffrey merged 2 commits intomainfrom
feat/audience-2-web-scaffold
Apr 7, 2026
Merged

feat(audience): scaffold @imtbl/audience-sdk package#2825
ImmutableJeffrey merged 2 commits intomainfrom
feat/audience-2-web-scaffold

Conversation

@ImmutableJeffrey
Copy link
Copy Markdown
Contributor

@ImmutableJeffrey ImmutableJeffrey commented Apr 5, 2026 •
edited
Loading

Summary

Scaffolds the @imtbl/audience-sdk package with minimal exports for the web SDK.

  • Package scaffold: package.json, tsconfig, eslint, jest config
  • Add packages/audience/sdk to pnpm-workspace.yaml
  • AudienceSDKConfig type, library name/version constants
  • Context wrapper (passes SDK library name to core's collectContext)
  • DebugLogger for dev mode
  • Tests for DebugLogger and collectContext

Test plan

  • npx nx test @imtbl/audience-sdk — all tests pass
  • npx nx build @imtbl/audience-sdk — builds clean

🤖 Generated with Claude Code

@ImmutableJeffrey ImmutableJeffrey mentioned this pull request Apr 5, 2026
Merged
2 tasks
@ImmutableJeffrey ImmutableJeffrey force-pushed the feat/audience-2-web-scaffold branch from 739a16a to bfd4618 Compare April 5, 2026 23:26
@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Apr 5, 2026 •
edited
Loading

View your CI Pipeline Execution ↗ for commit ede8be8

Command Status Duration Result
nx affected -t build,lint,test ✅ Succeeded 2m 10s View ↗
nx run-many -p @imtbl/sdk,@imtbl/checkout-widge... ✅ Succeeded 1m 1s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-07 09:18:04 UTC

@ImmutableJeffrey ImmutableJeffrey force-pushed the feat/audience-2-web-scaffold branch 2 times, most recently from e4fe335 to a404b5e Compare April 6, 2026 11:41
@ImmutableJeffrey ImmutableJeffrey force-pushed the feat/audience-1-core-fixes branch from 613d44d to 24a1dd6 Compare April 6, 2026 15:05
@ImmutableJeffrey ImmutableJeffrey force-pushed the feat/audience-2-web-scaffold branch 2 times, most recently from dae297d to b90f61a Compare April 6, 2026 15:27
@ImmutableJeffrey ImmutableJeffrey force-pushed the feat/audience-1-core-fixes branch from 24a1dd6 to ac6023c Compare April 6, 2026 23:04
@ImmutableJeffrey ImmutableJeffrey force-pushed the feat/audience-2-web-scaffold branch 2 times, most recently from 45ebb0b to ed3509e Compare April 6, 2026 23:27
@ImmutableJeffrey ImmutableJeffrey force-pushed the feat/audience-1-core-fixes branch from ac6023c to deb2408 Compare April 6, 2026 23:27
@ImmutableJeffrey ImmutableJeffrey force-pushed the feat/audience-2-web-scaffold branch from ed3509e to 45967cd Compare April 6, 2026 23:38
@ImmutableJeffrey ImmutableJeffrey force-pushed the feat/audience-1-core-fixes branch from deb2408 to f54168f Compare April 7, 2026 01:10
@ImmutableJeffrey ImmutableJeffrey force-pushed the feat/audience-2-web-scaffold branch 2 times, most recently from f8e493a to d7cbd5d Compare April 7, 2026 01:48
@ImmutableJeffrey ImmutableJeffrey force-pushed the feat/audience-1-core-fixes branch from f54168f to 7c161d7 Compare April 7, 2026 01:48
@ImmutableJeffrey ImmutableJeffrey force-pushed the feat/audience-2-web-scaffold branch from d7cbd5d to af5828c Compare April 7, 2026 02:19
@ImmutableJeffrey ImmutableJeffrey force-pushed the feat/audience-1-core-fixes branch from 7c161d7 to bad21ca Compare April 7, 2026 02:19
@ImmutableJeffrey ImmutableJeffrey force-pushed the feat/audience-2-web-scaffold branch from af5828c to 7ecb14c Compare April 7, 2026 02:34
Base automatically changed from feat/audience-1-core-fixes to main April 7, 2026 03:01
@ImmutableJeffrey ImmutableJeffrey force-pushed the feat/audience-2-web-scaffold branch 3 times, most recently from d7e6011 to 7ecb14c Compare April 7, 2026 03:51
@ImmutableJeffrey ImmutableJeffrey marked this pull request as ready for review April 7, 2026 04:42
@ImmutableJeffrey ImmutableJeffrey requested review from a team as code owners April 7, 2026 04:42
nattb8
nattb8 reviewed Apr 7, 2026
View reviewed changes
Comment thread packages/audience/core/src/config.ts
nattb8
nattb8 reviewed Apr 7, 2026
View reviewed changes
Comment thread packages/x-client/src/utils/stark/starkCurve.test.ts Outdated
nattb8
nattb8 reviewed Apr 7, 2026
View reviewed changes
Comment thread pnpm-workspace.yaml Outdated
nattb8
nattb8 reviewed Apr 7, 2026
View reviewed changes
Comment thread packages/audience/sdk/src/types.ts
nattb8
nattb8 reviewed Apr 7, 2026
View reviewed changes
Comment thread packages/audience/web/src/consent.ts Outdated
nattb8
nattb8 reviewed Apr 7, 2026
View reviewed changes
Comment thread packages/audience/web/src/consent.ts Outdated
nattb8
nattb8 reviewed Apr 7, 2026
View reviewed changes
Comment thread packages/audience/web/src/cookie.ts Outdated
nattb8
nattb8 reviewed Apr 7, 2026
View reviewed changes
Comment thread packages/audience/web/src/consent.ts Outdated
nattb8
nattb8 reviewed Apr 7, 2026
View reviewed changes
Comment thread packages/audience/web/src/consent.ts Outdated
@ImmutableJeffrey ImmutableJeffrey force-pushed the feat/audience-2-web-scaffold branch from a94da92 to 63a4236 Compare April 7, 2026 05:46
@ImmutableJeffrey ImmutableJeffrey changed the base branch from main to SDK-50-pixel-core-consent April 7, 2026 06:24
@ImmutableJeffrey ImmutableJeffrey force-pushed the feat/audience-2-web-scaffold branch 2 times, most recently from d8ac882 to a5c1ea2 Compare April 7, 2026 06:51
nattb8
nattb8 reviewed Apr 7, 2026
View reviewed changes
Comment thread packages/checkout/sdk/src/connect/connect.test.ts
nattb8
nattb8 reviewed Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@nattb8 nattb8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR summary needs to be updated e.g. doesn't implement ConsentManager anymore

nattb8
nattb8 reviewed Apr 7, 2026
View reviewed changes
Comment thread packages/audience/sdk/src/index.ts
@ImmutableJeffrey ImmutableJeffrey requested a review from a team as a code owner April 7, 2026 07:51
@ImmutableJeffrey ImmutableJeffrey force-pushed the feat/audience-2-web-scaffold branch from aeec230 to 55328bd Compare April 7, 2026 08:04
@ImmutableJeffrey ImmutableJeffrey changed the base branch from SDK-50-pixel-core-consent to main April 7, 2026 08:24
@ImmutableJeffrey ImmutableJeffrey force-pushed the feat/audience-2-web-scaffold branch from de470a4 to ac330ca Compare April 7, 2026 08:27
ImmutableJeffrey and others added 2 commits April 7, 2026 19:01
@ImmutableJeffrey @claude
feat(audience): scaffold @imtbl/audience-sdk package
1fc4991 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@ImmutableJeffrey @claude
test(audience): add tests for DebugLogger and collectContext
ede8be8 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@ImmutableJeffrey ImmutableJeffrey force-pushed the feat/audience-2-web-scaffold branch from ac330ca to ede8be8 Compare April 7, 2026 09:01
@ImmutableJeffrey ImmutableJeffrey changed the title feat(audience): scaffold @imtbl/audience-web-sdk with consent and cookies feat(audience): scaffold @imtbl/audience-sdk package Apr 7, 2026
@ImmutableJeffrey ImmutableJeffrey added this pull request to the merge queue Apr 7, 2026
Merged via the queue into main with commit b0fee26 Apr 7, 2026
8 checks passed
@ImmutableJeffrey ImmutableJeffrey deleted the feat/audience-2-web-scaffold branch April 7, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nattb8 nattb8 nattb8 approved these changes

@rodrigo-fournier-immutable rodrigo-fournier-immutable rodrigo-fournier-immutable approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ImmutableJeffrey @nattb8 @rodrigo-fournier-immutable