feat(pixel): add identityType parameter to identify()#2840
Merged
Conversation
Add required identityType parameter (second arg) to Pixel.identify() so the backend can distinguish which identity system a user ID belongs to (passport, steam, epic, etc.). Uses the shared IdentityType union from @imtbl/audience-core for parity with the web SDK. Closes SDK-77 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
View your CI Pipeline Execution ↗ for commit 1eacdbe
☁️ Nx Cloud last updated this comment at |
✅ Pixel Bundle Size — @imtbl/pixel
Budget: 10.00 KB gzipped (warn at 8.00 KB) |
nattb8
previously approved these changes
Apr 9, 2026
The bootstrap command handler only forwarded two args to identify(), silently dropping traits. Forward all three args to match the updated Pixel.identify(userId, identityType, traits?) signature. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ImmutableJeffrey
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
identityType: IdentityTypeparameter (second arg) toPixel.identify()so the backend can distinguish which identity system a user ID belongs to (passport,steam,epic, etc.)IdentityTypeunion from@imtbl/audience-core— same source of truth as the web SDKuserId,identityType,traits) toidentify()API change
Test plan
identityTypeidentify()without traits still sendsidentityTypeCloses SDK-77
🤖 Generated with Claude Code