Skip to content

feat(audience): rename event property keys to snake_case [SDK-412]#2875

Merged
nattb8 merged 1 commit into
mainfrom
feat/sdk-412-snake-case-event-props
May 22, 2026
Merged

feat(audience): rename event property keys to snake_case [SDK-412]#2875
nattb8 merged 1 commit into
mainfrom
feat/sdk-412-snake-case-event-props

Conversation

@nattb8
Copy link
Copy Markdown
Contributor

@nattb8 nattb8 commented May 22, 2026

Renames all multi-word Audience event property keys from camelCase to snake_case to align with industry standard (Segment, GA4). Event names were already snake_case; this makes properties consistent.

UTM params and click IDs (utm_source, gclid, etc.) are unchanged — they were already snake_case.

Fixes SDK-412.


Note

Medium Risk
This is a breaking schema change: event payload property names emitted by both @imtbl/audience and @imtbl/pixel are renamed, which can break downstream analytics pipelines and integrator code expecting camelCase.

Overview
Standardizes all multi-word event property keys from camelCase to snake_case across the web SDK and pixel (e.g. session_id, game_id, item_id, duration_sec, email_hash, ga_client_id).

Updates pixel autocapture payloads (forms/links/sessions/3rd-party IDs), SDK typed event interfaces and compile-time tests, and aligns sample-app/docs; bumps @imtbl/pixel to 0.3.0.

Reviewed by Cursor Bugbot for commit 19c9b78. Bugbot is set up for automated code reviews on this repo. Configure here.

@nattb8 nattb8 requested a review from a team as a code owner May 22, 2026 01:34
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented May 22, 2026

View your CI Pipeline Execution ↗ for commit 4f8531b

Command Status Duration Result
nx affected -t build,lint,test ✅ Succeeded 8s View ↗
nx run-many -p @imtbl/sdk,@imtbl/checkout-widge... ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2026-05-22 03:09:13 UTC

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 22, 2026

✅ Pixel Bundle Size — @imtbl/pixel

Metric Size Delta vs main
Gzipped 6347 bytes (6.19 KB) -3 bytes
Raw (minified) 17468 bytes +18 bytes

Budget: 10.00 KB gzipped (warn at 8.00 KB)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 22, 2026

✅ Audience Bundle Size — @imtbl/audience

Metric Size Delta vs main (60a837f)
Gzipped 18710 bytes (18.27 KB) +6 bytes
Raw (minified) 54679 bytes +4 bytes

Budget: 24.00 KB gzipped (warn at 20.00 KB)

@nattb8 nattb8 enabled auto-merge May 22, 2026 01:40
@nattb8 nattb8 added this pull request to the merge queue May 22, 2026
Comment thread packages/audience/pixel/src/pixel.test.ts
@nattb8 nattb8 removed this pull request from the merge queue due to a manual request May 22, 2026
@nattb8 nattb8 force-pushed the feat/sdk-412-snake-case-event-props branch from 3396989 to 46fefc0 Compare May 22, 2026 01:55
@nattb8 nattb8 enabled auto-merge May 22, 2026 01:55
Comment thread packages/audience/sdk/src/sdk.ts
Comment thread packages/audience/sdk/src/events.ts
@nattb8 nattb8 added this pull request to the merge queue May 22, 2026
@nattb8 nattb8 removed this pull request from the merge queue due to a manual request May 22, 2026
@nattb8 nattb8 force-pushed the feat/sdk-412-snake-case-event-props branch 2 times, most recently from 8df2d44 to 235c5e7 Compare May 22, 2026 02:11
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 235c5e7. Configure here.

Comment thread packages/audience/sdk-sample-app/README.md Outdated
@nattb8 nattb8 force-pushed the feat/sdk-412-snake-case-event-props branch from 235c5e7 to 4f8531b Compare May 22, 2026 02:52
@nattb8 nattb8 requested a review from ImmutableJeffrey May 22, 2026 03:03
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@nattb8 nattb8 force-pushed the feat/sdk-412-snake-case-event-props branch from 4f8531b to 19c9b78 Compare May 22, 2026 03:08
@nattb8 nattb8 enabled auto-merge May 22, 2026 03:10
@nattb8 nattb8 added this pull request to the merge queue May 22, 2026
Merged via the queue into main with commit 7067d1b May 22, 2026
12 checks passed
@nattb8 nattb8 deleted the feat/sdk-412-snake-case-event-props branch May 22, 2026 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants