Skip to content

feat(audience): add core types (AudienceConfig, ConsentLevel, AudienceError, Constants)#682

Merged
nattb8 merged 6 commits into
mainfrom
feat/sdk-119-audience-core-types
Apr 14, 2026
Merged

feat(audience): add core types (AudienceConfig, ConsentLevel, AudienceError, Constants)#682
nattb8 merged 6 commits into
mainfrom
feat/sdk-119-audience-core-types

Conversation

@nattb8
Copy link
Copy Markdown
Collaborator

@nattb8 nattb8 commented Apr 13, 2026

Summary

Adds the Audience public types needed before any implementation work can begin.

Linear: SDK-119

🤖 Generated with Claude Code

@nattb8 nattb8 requested review from a team as code owners April 13, 2026 22:50
…eError, Constants)

Adds public types needed before any implementation work begins:

- AudienceConfig: PublishableKey, Consent, DistributionPlatform, Debug,
  FlushIntervalSeconds, FlushSize, OnError. No Environment field.
- ConsentLevel: None / Anonymous / Full
- AudienceError + AudienceErrorCode
- Constants: key-prefix URL routing, API paths, flush defaults,
  DistributionPlatforms string constants
- ImmutableAudience: wire in Init(AudienceConfig) now that the type exists

Linear: SDK-119
@nattb8 nattb8 force-pushed the feat/sdk-118-audience-package-scaffold branch from 8a8a3ea to 81cd297 Compare April 13, 2026 23:03
@nattb8 nattb8 force-pushed the feat/sdk-119-audience-core-types branch from 3d0dd95 to efeda6a Compare April 13, 2026 23:03
Base automatically changed from feat/sdk-118-audience-package-scaffold to main April 14, 2026 02:02
nattb8 and others added 5 commits April 15, 2026 10:58
- Remove RFC comment and rename TestKeyPrefix -> SandboxKeyPrefix in Constants
- Drop Status and Endpoint from AudienceError (leaked internal HTTP details)
- Move OnError from AudienceConfig callback property to a static event on
  ImmutableAudience, following the same pattern as Passport.OnAuthEvent

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…Error scaffold

TestKeyPrefix matches the prod/test mental model consumers have.
OnError belongs in the implementation PR (SDK-99), not the scaffold.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
No sample app yet; add back when examples/audience is created.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…butionPlatforms

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@nattb8 nattb8 merged commit a680432 into main Apr 14, 2026
17 checks passed
@nattb8 nattb8 deleted the feat/sdk-119-audience-core-types branch April 14, 2026 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants