Skip to content

chore: create unity project#703

Merged
ImmutableJeffrey merged 2 commits into
mainfrom
chore/audience-example-project
Apr 23, 2026
Merged

chore: create unity project#703
ImmutableJeffrey merged 2 commits into
mainfrom
chore/audience-example-project

Conversation

@ImmutableJeffrey
Copy link
Copy Markdown
Collaborator

@ImmutableJeffrey ImmutableJeffrey commented Apr 23, 2026

Summary

  • Adds a minimal Unity project at examples/audience/ for verifying the com.immutable.audience package compiles inside the Unity Editor.
  • Manifest references the package via file:../../../src/Packages/Audience, matching the existing examples/passport/ pattern.

Known issue for reviewers

Opening this branch alone in Unity will fail to compile: src/Packages/Audience/Tests/Runtime/Transport/HttpTransportTests.cs:378 uses Assert.DoesNotThrowAsync, which is absent from the NUnit that ships with com.unity.test-framework 1.1.33. Fix will follow in a separate PR. Merge this PR together with or after that fix.

Test plan

  • Open examples/audience/ in Unity Hub (Editor version per ProjectSettings/ProjectVersion.txt).
  • Confirm package import succeeds and the manifest reference resolves.
  • After the NUnit fix merges, verify Console is free of red errors.

🤖 Generated with Claude Code


Note

Low Risk
Adds Unity project configuration and lockfiles only, with no production code or security-sensitive logic changes; main risk is repo churn/size and Unity version/package pin compatibility.

Overview
Adds a new minimal Unity project scaffold under examples/audience/, including Unity ProjectSettings/Packages configuration and a packages-lock.json, to serve as an editor-level compilation/packaging smoke test environment.

No runtime/package code is changed; this PR primarily introduces Unity-generated settings/assets metadata (input/quality/graphics/audio/etc.) pinned to Unity 2021.3.45f2.

Reviewed by Cursor Bugbot for commit 31559b7. Bugbot is set up for automated code reviews on this repo. Configure here.

@ImmutableJeffrey ImmutableJeffrey requested review from a team as code owners April 23, 2026 07:15
nattb8
nattb8 previously approved these changes Apr 23, 2026
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 813ea99. Configure here.

"com.unity.modules.wind": "1.0.0",
"com.unity.modules.xr": "1.0.0"
}
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Audience package reference missing from manifest

High Severity

The manifest.json is missing the com.immutable.audience dependency entry. The PR description states the manifest references the package via file:../../../src/Packages/Audience, and the existing examples/passport/ pattern includes "com.immutable.passport": "file:../../../src/Packages/Passport" — but the audience manifest has no such entry. Without it, this example project cannot fulfill its stated purpose of verifying the audience package compiles in the Unity Editor.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 813ea99. Configure here.

Comment thread examples/audience/ProjectSettings/ProjectSettings.asset Outdated
@ImmutableJeffrey ImmutableJeffrey force-pushed the chore/audience-example-project branch from a36d70d to 31559b7 Compare April 23, 2026 07:22
@ImmutableJeffrey ImmutableJeffrey merged commit 36052da into main Apr 23, 2026
19 checks passed
@ImmutableJeffrey ImmutableJeffrey deleted the chore/audience-example-project branch April 23, 2026 07:30
@github-actions github-actions Bot added the chore label Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants