Skip to content

refactor(audience-sample-app): drop log row count cap #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ImmutableJeffrey merged 1 commit into from
Apr 28, 2026
Merged

refactor(audience-sample-app): drop log row count cap #714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions examples/audience/Assets/SampleApp/Scripts/AudienceSample.UI.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ private static readonly (string TabId, string PanelId)[] Tabs =

private static readonly string[] StateClasses = { "state-ok", "state-warn", "state-err", "dim" };

private const int LogCapacity = 200;
private const int CollapseThreshold = 240;
private const int StatusPollIntervalMs = 500;
private const float NarrowBreakpointPx = 1024f;
Expand Down Expand Up @@ -698,9 +697,6 @@ private void AppendLog(string label, string? body, LogLevel level, LogSource sou
return;
}

if (_logView.contentContainer.childCount >= LogCapacity)
_logView.contentContainer.RemoveAt(0);

// Snapshot "was at bottom?" before adding — stateless per-row check.
var s = _logView.verticalScroller;
bool wasAtBottom = s.highValue <= 0 || (s.highValue - s.value) < 4f;
Expand Down
Loading