WalletConnect v2#315
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hugomarquesdev
approved these changes
May 11, 2023
vibern0
force-pushed
the
feature/wallet-connect-v2
branch
from
5472a26 to
40fc452
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR update WalletConnect to v2, using the beta version of utils impactMarket/utils#224
Other changes:
next-manifest(incompatible)Current issues:
Unhandled Runtime Error - Error: Cancel rendering routewhich only happens when using an anchor, like/crypto-hub#stakingwhere do I put the manifest now (from next.config.js)?- solvedI'm having lots of typescript issues, Had to disable it!- solvedManual tests done: