Skip to content

Add missing tests for non-abstract classes and ensure tooling runs#79

Merged
MekDrop merged 2 commits intomainfrom
codex/add-missing-tests
Apr 2, 2026
Merged

Add missing tests for non-abstract classes and ensure tooling runs#79
MekDrop merged 2 commits intomainfrom
codex/add-missing-tests

Conversation

@Codex
Copy link
Copy Markdown
Contributor

@Codex Codex AI commented Apr 2, 2026

All non-abstract classes lacked coverage; tests must mirror src/ structure and tooling (phpunit/phpcs/phpstan) must pass.

  • New tests: Added targeted coverage for attributes, enums, helper utilities, translator facade, service locator, common property implementations, deprecated types, and custom exceptions under tests/ mirroring src/.
  • Service locator: Lazily builds service map to avoid const-expression failures while keeping behavior.
  • Tooling: phpstan script now uses vendor/bin/phpstan for reliable static analysis.

Example — enum mapping test:

#[DataProvider('typeClassProvider')]
public function testTypeClassMapping(DataType $case, string $expectedClass): void
{
    $this->assertSame($expectedClass, $case->getTypeClass());
}

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • upload.wikimedia.org
    • Triggering command: /usr/bin/php php /home/REDACTED/work/properties/properties/vendor/bin/phpunit t git chec�� '/home/REDACTED/.cache/composer/vcs/https---githubREDACTED '/home/REDACTED/.cache/composer/vcs/https---github.com-sebastianbergmann-complexity.git/' odex/vendor/x86_64-REDACTED-linux-musl/path/git -r 9c13726d4a715adbremote 0/x64/lib/node_madd git rese�� te' 'add' 'compoREDACTED 7989e43bf381af0eac72e4f0ca5bcbfa--reference /usr/local/sbin/lsmod .git com-sebastianber-m ebastian/diff lsmod (dns block)
    • Triggering command: /usr/bin/php php /home/REDACTED/work/properties/properties/vendor/bin/phpunit 0/x64/lib/node_m/home/REDACTED/work/properties/properties git pert�� k/properties/protests/Exceptions/ExceptionsTest.php git odules/@openai/codex/vendor/x86_64-REDACTED-linux-musl/path/lsb_release /ExceptionsTest.git hash-object /usr/local/.ghcu/home/REDACTED/work/properties/properties git -C perties hash-object k/_temp/ghcca-node/node/bin/git TypesTest.php hash-object -musl/path/git git (dns block)
    • Triggering command: /usr/bin/php php /home/REDACTED/work/properties/properties/vendor/bin/phpunit ndor/bin/git git -C perties hash-object odules/@openai/codex/vendor/x86_64-REDACTED-linux-musl/path/lsb_release pertiesTest.php hash-object git lsb_release -a k/_temp/ghcca-notests/Attribute/LinkedCaseTypeTest.php dirname ache/node/24.14.0/x64/lib/node_modules/@openai/codex/vendor/x86_64-REDACTED-linux-musl/path/git k/properties/progit git rgo/bin/git num\ValidationRuhash-object (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@Codex Codex AI assigned Codex and MekDrop Apr 2, 2026
@Codex Codex AI linked an issue Apr 2, 2026 that may be closed by this pull request
Co-authored-by: MekDrop <342641+MekDrop@users.noreply.github.com>
@Codex Codex AI changed the title [WIP] Add missing tests for non-abstract classes Add missing tests for non-abstract classes and ensure tooling runs Apr 2, 2026
@Codex Codex AI requested a review from MekDrop April 2, 2026 10:24
@MekDrop MekDrop marked this pull request as ready for review April 2, 2026 10:27
@MekDrop MekDrop merged commit cb659e4 into main Apr 2, 2026
5 checks passed
@MekDrop MekDrop deleted the codex/add-missing-tests branch April 2, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Add missing tests

2 participants