make exportmap procedures static instead of monkeypatching exportmap #2982
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following procedures:
are conceptually static methods of
ExportMap
, but instead of using thestatic
keyword they are monkey-patched onto theExportMap
classwhich is surprising.
Lets make them static methods proper.
Tip for the reviewer/maintainer:
Use the "Hide whitespace" feature of GitHub's diff.