feat(docker): use env vars for configDir and port on Imposter 5.x+#124
Merged
Conversation
Imposter 5.x dropped the --configDir and --listenPort CLI flags in favour of the IMPOSTER_CONFIG_DIR and IMPOSTER_PORT environment variables. Detect the engine version with semver and switch between CLI flags (4.x and earlier) and env vars (5.x+). Unparseable versions such as "dev" use the env-var form.
Add unit tests for usesEnvConfig, buildCmd, and buildEnv covering 3.x, 4.x, 5.x, 6.x, pre-release, unparseable, and file-cache combinations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch the Docker engine to set configDir and port via environment variables when running Imposter 5.x or later.
Summary
--configDir/--listenPortCLI flags for 4.x and earlier,IMPOSTER_CONFIG_DIR/IMPOSTER_PORTenv vars for 5.x+.dev) default to the env-var form so ongoing development tracks the new interface.Implementation details
Imposter 5.x removed the
--configDirand--listenPortCLI flags, so passing them asCmdargs breaks startup against newer images. The version check uses the existingcoreos/go-semverdependency. When the env-var path is taken,Cmdis left empty and the container falls back to the image's default entrypoint args.