Skip to content

fix: removes the -t argument from imposter down.#3

Merged
outofcoffee merged 2 commits into
imposter-project:mainfrom
zzcgumn:fix/drop-argument-in-stop-action
May 28, 2026
Merged

fix: removes the -t argument from imposter down.#3
outofcoffee merged 2 commits into
imposter-project:mainfrom
zzcgumn:fix/drop-argument-in-stop-action

Conversation

@zzcgumn
Copy link
Copy Markdown
Contributor

@zzcgumn zzcgumn commented May 28, 2026

No description provided.

@outofcoffee outofcoffee self-requested a review May 28, 2026 16:19
@outofcoffee outofcoffee self-assigned this May 28, 2026
@outofcoffee outofcoffee added the bug Something isn't working label May 28, 2026
The imposter-cli down command dropped the -t/--engine-type flag and now
takes a positional mock ID or --all. Passing the engine type as a value
made it parse as a mock ID, so stop the run with --all instead and mark
the engine-type input deprecated, warning when it is set.
@outofcoffee
Copy link
Copy Markdown
Contributor

Thanks for raising this, @zzcgumn — you correctly spotted that imposter down no longer accepts -t.

I've pushed a follow-up commit to this branch to round out the fix. The recent imposter-cli change didn't just drop the flag, it reworked the command's interface: down now takes a positional mock ID, or --all:

imposter down [ID]
imposter down --all

So imposter down ${{ inputs.engine-type }} passes the engine type as a positional argument, and the CLI treats it as a mock ID — e.g. imposter down docker exits with no managed mock found with ID "docker".

Since the action doesn't track individual mock IDs, the follow-up uses imposter down --all, which stops every managed mock regardless of engine type, matching the previous behaviour. While there I also:

  • marked the engine-type input as deprecated and log a warning if it's still set (it no longer affects down);
  • dropped its docker default, as it's now unused;
  • updated the README to match.

start-mocks keeps engine-type unchanged, since imposter up and imposter engine pull still use it.

@outofcoffee outofcoffee merged commit 160c1ed into imposter-project:main May 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants