feat: embed markdown images in PDF and add H2 page breaks#2
Merged
kevinjourdain-improving merged 2 commits intomainfrom Feb 11, 2026
Merged
Conversation
Collaborator
jglisson
commented
Feb 11, 2026
jglisson
commented
- Add _copy_images_to_temp() to copy referenced images into the temp directory alongside the rendered HTML, preserving relative paths so Chromium can resolve them during PDF generation
- Use a temp directory (mkdtemp) instead of a single temp file so image assets can be co-located with the HTML
- Add .content img CSS rule (max-width: 100%, height: auto) to constrain images to the page width
- Add page-break-before: always on .content h2 in print styles so each ## section starts on a new page (excludes .doc-subtitle)
- Add _copy_images_to_temp() to copy referenced images into the temp directory alongside the rendered HTML, preserving relative paths so Chromium can resolve them during PDF generation - Use a temp directory (mkdtemp) instead of a single temp file so image assets can be co-located with the HTML - Add .content img CSS rule (max-width: 100%, height: auto) to constrain images to the page width - Add page-break-before: always on .content h2 in print styles so each ## section starts on a new page (excludes .doc-subtitle)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.