Example NGINX Configs#161
Closed
hyperdefined wants to merge 3 commits into
Closed
Conversation
dumbmoron
reviewed
Jul 27, 2023
dumbmoron
reviewed
Jul 27, 2023
dumbmoron
reviewed
Jul 27, 2023
dumbmoron
reviewed
Jul 27, 2023
dumbmoron
reviewed
Jul 27, 2023
Member
|
nitpicked a few things, if you agree with any of my comments i think it would be a good idea to make the configs a little shorter, so they are a bit less complicated for someone less experienced with nginx to read |
Contributor
Author
|
Thank you, I am a NGINX noob myself so I will make changes soon! |
Member
|
nice, will take a look in a bit |
dumbmoron
reviewed
Jul 27, 2023
Member
|
also the keepalive stuff was fine imo, but its also fine if you wanna remove it since it doesnt really matter all that much other than that lgtm |
Contributor
Author
|
I figured it makes it cleaner and more easier to follow for new people. I'll actually fix the logging soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new folder called
web-configs. I added an example NGINX config on there, just to start. I've seen a few people ask about it in the Discord. Feel free to modify and change it.This new folder also lets anyone throw in their own configs for other software.