Skip to content

make all environment variables consistent & list them in docs#380

Merged
wukko merged 10 commits into7.11from
capitalize-env
Mar 5, 2024
Merged

make all environment variables consistent & list them in docs#380
wukko merged 10 commits into7.11from
capitalize-env

Conversation

@wukko
Copy link
Copy Markdown
Member

@wukko wukko commented Mar 5, 2024 •
edited
Loading

apiPort -> API_PORT
apiURL -> API_URL
apiName -> API_NAME
cors -> CORS_WILDCARD
cookiePath -> COOKIE_PATH

webPort -> WEB_PORT
webURL -> WEB_URL
showSponsors -> SHOW_SPONSORS
isBeta -> IS_BETA

wukko added 3 commits March 5, 2024 19:08
@wukko
env: readable environment variables in all files
e16ee6c 
apiPort -> API_PORT
apiURL -> API_URL
apiName -> API_NAME
cors -> ENABLE_CORS
cookiePath -> COOKIE_PATH

webPort -> WEB_PORT
webURL -> WEB_URL
showSponsors -> SHOW_SPONSORS
isBeta -> IS_BETA
@wukko
docker-compose example: update env variables & clearer messaging
a480221
@wukko
docs: added a list of all variables to run-an-instance.md
7656153
@wukko wukko changed the title make all environment variables consistent and readable make all environment variables consistent and readable + list of all of them in docs Mar 5, 2024
@wukko wukko changed the title make all environment variables consistent and readable + list of all of them in docs make all environment variables consistent and readable & list all of them in docs Mar 5, 2024
@wukko wukko changed the title make all environment variables consistent and readable & list all of them in docs make all environment variables consistent and readable & list them in docs Mar 5, 2024
@wukko wukko added this to the 7.11 milestone Mar 5, 2024
@wukko wukko changed the title make all environment variables consistent and readable & list them in docs make all environment variables consistent & list them in docs Mar 5, 2024
@wukko wukko requested a review from dumbmoron March 5, 2024 13:59
dumbmoron
dumbmoron requested changes Mar 5, 2024
View reviewed changes
Comment thread docs/run-an-instance.md Outdated
Comment thread src/core/api.js Outdated
@wukko wukko requested a review from dumbmoron March 5, 2024 14:14
dumbmoron
dumbmoron approved these changes Mar 5, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@dumbmoron dumbmoron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtv 👍

@wukko wukko changed the base branch from current to 7.11 March 5, 2024 14:18
@wukko wukko merged commit db6a755 into 7.11 Mar 5, 2024
@dumbmoron dumbmoron deleted the capitalize-env branch March 5, 2024 17:03
@wukko wukko mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dumbmoron dumbmoron dumbmoron approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.11

Development

Successfully merging this pull request may close these issues.

2 participants

@wukko @dumbmoron