Skip to content

Comments

Added Characterization and simple ULI build schema#10

Merged
Xarthisius merged 13 commits intoimqcam:mainfrom
APonugoti1:akhila
Aug 5, 2025
Merged

Added Characterization and simple ULI build schema#10
Xarthisius merged 13 commits intoimqcam:mainfrom
APonugoti1:akhila

Conversation

@APonugoti1
Copy link
Contributor

Hi @Xarthisius,

Could you please review and merge the changes at your earliest convenience?
Thank you!

@arachid1
Copy link
Collaborator

ULI characterization form has id that looks like 'CMXMAL00060-32 - 687fd3694f57c261a6d8e42b - no localId'. I think it should be CMUXX.YY, which should be the local id of the IGSN you're selecting.

@Xarthisius
Copy link
Contributor

Xarthisius commented Jul 31, 2025

Notes

  1. testing.json and uli_build_schema.json should be removed from this PR. The former doesn't belong at all, and the latter is out of scope.
  2. For simple_uli_build_schema.json it would be nice to have better definitions for b, d, l (width?, thickness?, length?) to better understand geometry. It also is important for point 3.
  3. uli_characterization_schema.json:
    1. It needs a better name and description. It's what users will see right away.
    2. Some of the fields should be read-only and calculated based on other fields. Look at the spreadsheet and in the columns check whether number that's displayed is a user provided value (e.g. R-ratio) or a formula (e.g. max(P) ). Formulas should be preserved and used automatically. Things like P-max will require linking to other form's entries (e.g. simple_uli_build_schema to get dimensions using preload/entryField functionality, example https://github.com/htmdec/htmax-forms/blob/main/specimen_processing_conditions.json )
    3. As noted by Ali there's no reasonable uniqueId (also applies to simple_uli_build_schema.json)

APonugoti1 and others added 3 commits August 4, 2025 11:12
@Xarthisius Xarthisius merged commit 60c257a into imqcam:main Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants