Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the printer build and raw powder schema JSON files to improve data structure, naming consistency, and conditional logic for powder testing fields. The most significant changes include restructuring how raw powders are referenced, renaming several file fields for clarity, and adding conditional dependencies for particle size and virgin percentage fields based on a new "tested" checkbox.
Schema structure and data relationships:
rawPowderIDfield inprinter_build_schema.jsonto an array of strings, allowing multiple raw powders to be referenced instead of just one.relatedIdentifiersfield fromprinter_build_schema.json, simplifying the schema and removing a hidden, readonly array of related identifier objects.Field naming and clarity:
openjzFiletobuildFileandeosReportFiletoreportFileinprinter_build_schema.jsonfor clearer and more generic file field names and descriptions.Conditional logic and options:
raw_powder_schema.json, added a "Tested?" checkbox (testedfield) to the particle size distribution group. All particle size and virgin percentage fields now depend on this checkbox being checked, improving data entry logic and UI clarity.Material naming consistency:
raw_powder_schema.jsonfrom"IN718"to"alloy718"for consistency with naming conventions.