Skip to content

Task v12/improve php spreadsheet dependency #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025
Merged

Task v12/improve php spreadsheet dependency #1218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Classes/Controller/AbstractController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
use TYPO3\CMS\Core\Configuration\Exception\ExtensionConfigurationExtensionNotConfiguredException;
use TYPO3\CMS\Core\Configuration\Exception\ExtensionConfigurationPathDoesNotExistException;
use TYPO3\CMS\Core\EventDispatcher\EventDispatcher;
use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
use TYPO3\CMS\Core\Utility\GeneralUtility;
use TYPO3\CMS\Extbase\Mvc\Controller\ActionController;
use TYPO3\CMS\Extbase\Mvc\Exception\NoSuchArgumentException;
Expand Down Expand Up @@ -110,7 +109,7 @@ public function __construct(
$this->uploadService = $uploadService;
$this->eventDispatcher = $eventDispatcher;

$this->isPhpSpreadsheetInstalled = ExtensionManagementUtility::isLoaded('base_excel');
$this->isPhpSpreadsheetInstalled = class_exists(\PhpOffice\PhpSpreadsheet\IOFactory::class);
}

/**
Expand Down
10 changes: 6 additions & 4 deletions Documentation/Index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,13 @@ look at the final output in the frontend.
Some basic points:

- Main features of this mailform extension is to store the mails into
the database. Export it from the backend module (xls, csv) or list the
the database.

- Export it from the backend module (xls, csv) or list the
values in the frontend again (Pi2). XLS export in the backend is only
possible if the extension *jambagecom/base-excel* is installed. In
classic installation, a phar file for phpspreadsheet must be manually
created (See docs of EXT:base_excel).
possible for classic installation, if a phar file for phpspreadsheet is manually
created (See docs of EXT:base_excel). In composer-based installation the neccessary
package is installed automatically.

- Powermail send one or more mails to a static receiver or to dynamic receivers or
to a whole Frontend-User Group.
Expand Down
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@
"ext-curl": "*"
},
"suggest": {
"sjbr/static-info-tables": "*",
"jambagecom/base-excel": "^v1.29.0"
"sjbr/static-info-tables": "Provides country information for the country field",
"phpoffice/phpspreadsheet": "Enables xlsx export via the powermail module"
},
"replace": {
"typo3-ter/powermail": "self.version"
Expand Down
1 change: 1 addition & 0 deletions ext_emconf.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
'conflicts' => [
],
'suggests' => [
'base_excel' => '',
'static_info_tables' => ''
],
],
Expand Down