Skip to content

[BUGFIX] Prevent undefined global variable #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2025
+43 −15
Merged

[BUGFIX] Prevent undefined global variable #1288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 43 additions & 15 deletions Classes/Utility/FrontendUtility.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,21 @@ public static function getStoragePage(int $pid = 0): int
*/
public static function getCurrentPageIdentifier(): int
{
return self::getRequest()->getAttribute('frontend.page.information')->getId() ?? 0;
if (self::getRequest() !== null) {
return self::getRequest()->getAttribute('frontend.page.information')->getId() ?? 0;
}
return 0;
}

/**
* Get configured frontend language
*/
public static function getSysLanguageUid(): int
{
return self::getRequest()->getAttribute('language')->getLanguageId();
if (self::getRequest() !== null) {
return self::getRequest()->getAttribute('language')->getLanguageId();
}
return 0;
}

public static function getPluginName(): string
Expand Down Expand Up @@ -91,13 +97,17 @@ public static function isAllowedToEdit(array $settings, $mail): bool
$mail = $mailRepository->findByUid((int)$mail);
}

$userObject = self::getRequest()->getAttribute('frontend.user');
$feUser = self::getRequest()->getAttribute('frontend.user')->getUserId();
$request = self::getRequest();
if ($request === null) {
return false;
}

$feUser = $request->getAttribute('frontend.user')->getUserId();
if ($feUser === 0 || $mail === null) {
return false;
}

$usergroups = self::getRequest()->getAttribute('frontend.user')->createUserAspect()->getGroupIds();
$usergroups = $request->getAttribute('frontend.user')->createUserAspect()->getGroupIds();
$usersSettings = GeneralUtility::trimExplode(',', $settings['edit']['feuser'] ?? '', true);
$usergroupsSettings = GeneralUtility::trimExplode(',', $settings['edit']['fegroup'] ?? '', true);

Expand All @@ -123,7 +133,13 @@ public static function isAllowedToEdit(array $settings, $mail): bool

public static function isAllowedToView(array $settings, Mail $mail): bool
{
$feUser =self::getRequest()->getAttribute('frontend.user')->getUserId();
$request = self::getRequest();

if ($request === null) {
return false;
}

$feUser = $request->getAttribute('frontend.user')->getUserId();
if (
$feUser === 0 ||
(
Expand All @@ -142,16 +158,25 @@ public static function isAllowedToView(array $settings, Mail $mail): bool
*/
public static function isLoggedInFrontendUser(): bool
{
return self::getRequest()->getAttribute('frontend.user')->isActiveLogin(self::getRequest());
$request = self::getRequest();
if ($request !== null) {
return $request->getAttribute('frontend.user')->isActiveLogin($request);
}

return false;
}

/**
* Get Property from currently logged in fe_user
*/
public static function getPropertyFromLoggedInFrontendUser(string $propertyName = 'uid'): string
{
$feUser = self::getRequest()->getAttribute('frontend.user');
return (string)($feUser->user[$propertyName] ?? '');
$request = self::getRequest();
if ($request !== null) {
$feUser = $request->getAttribute('frontend.user');
return (string)($feUser->user[$propertyName] ?? '');
}
return '';
}

/**
Expand Down Expand Up @@ -254,16 +279,19 @@ protected static function getArgumentsFromGetOrPostRequest(string $key): array

protected static function getArgumentsFromTyposcriptFrontendController(string $key): array
{
$pageArguments = self::getRequest()->getAttribute('routing');
$arguments = $pageArguments->getArguments();
if (array_key_exists($key, $arguments)) {
return (array)$arguments[$key];
$request = self::getRequest();
if ($request !== null) {
$pageArguments = $request->getAttribute('routing');
$arguments = $pageArguments->getArguments();
if (array_key_exists($key, $arguments)) {
return (array)$arguments[$key];
}
}
return [];
}

protected static function getRequest(): ServerRequestInterface
protected static function getRequest(): ?ServerRequestInterface
{
return $GLOBALS['TYPO3_REQUEST'];
return $GLOBALS['TYPO3_REQUEST'] ?? null;
}
}