Skip to content

[BUGFIX] Prevent infinite loop when trustedProperties validation fails #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2025
Merged

[BUGFIX] Prevent infinite loop when trustedProperties validation fails #1294

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1be3c18
[BUGFIX] Prevent infinite loop when trustedProperties validation fails
lorenzulrich Sep 25, 2025
e44ea77
fix: Add BadRequestException import to FormController
lorenzulrich Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Classes/Controller/FormController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
use In2code\Powermail\Utility\ObjectUtility;
use In2code\Powermail\Utility\SessionUtility;
use In2code\Powermail\Utility\TemplateUtility;
use TYPO3\CMS\Core\Error\Http\BadRequestException;
use function in_array;
use Psr\EventDispatcher\EventDispatcherInterface;
use Psr\Http\Message\ResponseInterface;
Expand Down Expand Up @@ -609,6 +610,17 @@ public function processRequest(RequestInterface $request): ResponseInterface
return parent::processRequest($request);
} catch (PropagateResponseException $e) {
return $e->getResponse();
} catch (BadRequestException $e) {
if (in_array($e->getCode(), [1581862822, 1699604555, 1691267306])) {
// If the trustedProperties HMAC can not be validated, we redirect to an empty form because the
// request cannot be salvaged and would lead to an infinite loop.
$logger = ObjectUtility::getLogger(__CLASS__);
$logger->warning('Redirecting to empty form because HMAC validation failed.', [$e->getMessage()]);
return $this->redirect('form');
}
$logger = ObjectUtility::getLogger(__CLASS__);
$logger->critical('An error occurred: ', [$e->getMessage()]);
return (new ForwardResponse('form'))->withoutArguments();
} catch (\Exception $e) {
$logger = ObjectUtility::getLogger(__CLASS__);
$logger->critical('An error occurred: ', [$e->getMessage()]);
Expand Down
Loading