Merged
Conversation
Contributor
Author
|
Reviewers: any thoughts on this? I know the tests are failing but I assume those are specific to 8.xx versions of rocq. |
Member
|
Putting this into a branch and try to figure out how backward compatible we can be is a good idea. We talked at a group meeting about how we're okay dropping support for things before 9.0 if we can't get things compatable, since the older version will remain available. I'll go ahead and merge this and update the CI. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’ve tested this with rocq v9.0.01 and 9.1.0. I’m not sure that I updated the dune files correctly though.
I included updates that address the warnings about deprecated notation and syntax, and I suspect these may have broken backward compatibility with v8.xx, but it would probably be good to check and see if this can be something semi-compatible. I only submitted a PR to a branch until we figured that out.