Skip to content

Conversation

@althonos
Copy link

Hi!

As reported by @vagkaratzas in althonos/pytrimal#5 it seems that the -clusters issue from the CLI doesn't work as expected, as even example runs seem to always return the full alignment rather than the cluster representatives.

Digging a bit into this, I noticed that the Cleaner::getCutPointClusters was returning +inf as the identity cut point, which was causing all sequences to be selected. In several places of the function code, variables were not properly initialized and/or reinitialized, which was causing inconsistent behavior across executions, followed by a division-by-zero which was causing +inf to be returned.

I fixed the Cleaner::getCutPointClusters code so that now the -clusters option works as expected. In addition, I added some missing #include statements which were preventing the project from compiling with GCC 15.2.1, at least on my machine.

@scapella scapella merged commit 87207c3 into inab:2.0_RC Aug 18, 2025
0 of 12 checks passed
@althonos
Copy link
Author

Thanks @scapella !

@scapella
Copy link
Collaborator

Thanks for your contributions to the code. It has been a long time since I wrote that code, and those fixes seem obvious to me now :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants