Fix -clusters options from the CLI
#117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
As reported by @vagkaratzas in althonos/pytrimal#5 it seems that the
-clustersissue from the CLI doesn't work as expected, as even example runs seem to always return the full alignment rather than the cluster representatives.Digging a bit into this, I noticed that the
Cleaner::getCutPointClusterswas returning+infas the identity cut point, which was causing all sequences to be selected. In several places of the function code, variables were not properly initialized and/or reinitialized, which was causing inconsistent behavior across executions, followed by a division-by-zero which was causing+infto be returned.I fixed the
Cleaner::getCutPointClusterscode so that now the-clustersoption works as expected. In addition, I added some missing#includestatements which were preventing the project from compiling with GCC 15.2.1, at least on my machine.