first commit of styleguide for SQL code#169
Merged
fredericpiesschaert merged 2 commits intomasterfrom Jun 30, 2020
Merged
Conversation
florisvdh
changed the title
Member
|
This PR addresses #9 . |
after discussion with Gert VS
florisvdh
reviewed
Jun 30, 2020
Member
There was a problem hiding this comment.
Nice and very interesting @fredericpiesschaert 🎉 Thanks a lot for making a tutorial on SQL styling.
Some minor remaining comments:
- typo: meaningfull -> meaningful
- lowercase aliases: better also use lowercase
utm1? - I have the impression that you consistently put whitespace around relational operators (= > ...), maybe that's also something to point out as a styling rule. The only place where you deviate from that is in
WHERE 1=1, perhaps then1 = 1is better then? Your decision, of course 😉
fredericpiesschaert
added a commit
that referenced
this pull request
Sep 3, 2020
see comments of Floris --> #169 (review)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.