Skip to content

Conversation

@jobveldhuis
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 9, 2025 13:09
@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2025

🦋 Changeset detected

Latest commit: e25d73b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@incentro-ic/config-eslint Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR resolves a conflict between ESLint rules by disabling @typescript-eslint/non-nullable-type-assertion-style, which would otherwise encourage using non-null assertions (!) over explicit type assertions. This allows developers to use explicit type assertions when dealing with complex typing scenarios.

Key Changes:

  • Disabled the @typescript-eslint/non-nullable-type-assertion-style rule to prevent conflicts with @typescript-eslint/no-non-null-assertion
  • Added comprehensive documentation explaining the rationale for this configuration choice

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/eslint/src/partials/typescript.ts Adds rule configuration to disable non-nullable-type-assertion-style with detailed comment explaining the conflict with existing rules
.changeset/eight-rockets-care.md Adds changeset entry documenting this configuration change as a minor version update

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@LuudJanssen
Copy link
Member

Makes sense, I also support an explicit as NonNullable<Type> over allowing all non-null assertions.

@LuudJanssen LuudJanssen self-assigned this Dec 9, 2025
@jobveldhuis jobveldhuis merged commit 6e69e9b into main Dec 9, 2025
2 checks passed
@jobveldhuis jobveldhuis deleted the fix/resolve-conflicting-ruleset branch December 9, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants