Skip to content

#6012 - Auto-formatting for code#6013

Merged
reckart merged 3 commits into
release/40.xfrom
refactoring/6012-Auto-formatting-for-code
May 7, 2026
Merged

#6012 - Auto-formatting for code#6013
reckart merged 3 commits into
release/40.xfrom
refactoring/6012-Auto-formatting-for-code

Conversation

@reckart
Copy link
Copy Markdown
Member

@reckart reckart commented May 7, 2026

What's in the PR

  • Add Spotless Maven plugin with Eclipse formatter integration; skip in doc-only profile
  • Update Eclipse formatter profile (DKProStyle_latest.xml): tweak record/type declaration formatting, switch case alignment, annotation alignment, and other newly-supported keys
  • Strip compiler/JVM settings from shared org.eclipse.jdt.core.prefs so it carries only formatter keys
  • Rework installEclipseSettings.sh: proper shebang, set -eu, merge formatter keys into existing per-module prefs (preserving compiler settings), POSIX-compliant function syntax, replace find -exec with submodule loop
  • Reformat embedded JS text blocks in StickyColumnHeaderBehavior and StickyRowHeaderBehavior to standard indentation
  • Add trailing newlines to several MTAS upstream source files

How to test manually

  • No specific test procedure

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart reckart added this to the 40.4 milestone May 7, 2026
@reckart reckart self-assigned this May 7, 2026
@reckart reckart added this to Kanban May 7, 2026
@github-project-automation github-project-automation Bot moved this to 🔖 To do in Kanban May 7, 2026
- Add Spotless Maven plugin with Eclipse formatter integration; skip in `doc-only` profile
- Update Eclipse formatter profile (`DKProStyle_latest.xml`): tweak record/type declaration formatting, switch case alignment, annotation alignment, and other newly-supported keys
- Strip compiler/JVM settings from shared `org.eclipse.jdt.core.prefs` so it carries only formatter keys
- Rework `installEclipseSettings.sh`: proper shebang, `set -eu`, merge formatter keys into existing per-module prefs (preserving compiler settings), POSIX-compliant function syntax, replace `find -exec` with submodule loop
- Reformat embedded JS text blocks in `StickyColumnHeaderBehavior` and `StickyRowHeaderBehavior` to standard indentation
- Add trailing newlines to several MTAS upstream source files
@reckart reckart force-pushed the refactoring/6012-Auto-formatting-for-code branch from 734be96 to bfc0891 Compare May 7, 2026 19:31
reckart added 2 commits May 7, 2026 21:40
- Trim checkstyle rules so they don't overlap with spotless
- Add pre-commit hook
@reckart reckart merged commit 1d03b91 into release/40.x May 7, 2026
4 checks passed
@reckart reckart deleted the refactoring/6012-Auto-formatting-for-code branch May 7, 2026 21:02
@github-project-automation github-project-automation Bot moved this from 🔖 To do to 🍹 Done in Kanban May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 🍹 Done

Development

Successfully merging this pull request may close these issues.

1 participant