Skip to content

hotfix: pass correct default model per pack (fixes codex-cli 400) #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
royosherove merged 1 commit into from
Apr 16, 2026
Merged

hotfix: pass correct default model per pack (fixes codex-cli 400) #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1104,17 +1104,34 @@ collect_security_config() {
# Parameter source-of-truth: single mapping for CFN Console, CFN CLI, Terraform
# ============================================================================
# ⚠ KEEP THESE THREE ARRAYS IN SYNC — same order, same count
PARAM_CFN_NAMES=(EnvironmentName PackName ProfileName InstanceType ModelMode BedrockRegion LokiWatermark EnableBedrockForm EnableSecurityHub EnableGuardDuty EnableInspector EnableAccessAnalyzer EnableConfigRecorder ExistingVpcId ExistingSubnetId RepoBranch)
PARAM_TF_NAMES=(environment_name pack_name profile_name instance_type model_mode bedrock_region loki_watermark enable_bedrock_form enable_security_hub enable_guardduty enable_inspector enable_access_analyzer enable_config_recorder existing_vpc_id existing_subnet_id repo_branch)
PARAM_CFN_NAMES=(EnvironmentName PackName ProfileName InstanceType DefaultModel ModelMode BedrockRegion LokiWatermark EnableBedrockForm EnableSecurityHub EnableGuardDuty EnableInspector EnableAccessAnalyzer EnableConfigRecorder ExistingVpcId ExistingSubnetId RepoBranch)
PARAM_TF_NAMES=(environment_name pack_name profile_name instance_type default_model model_mode bedrock_region loki_watermark enable_bedrock_form enable_security_hub enable_guardduty enable_inspector enable_access_analyzer enable_config_recorder existing_vpc_id existing_subnet_id repo_branch)
PARAM_VALUES=() # populated by build_deploy_params()

# Per-pack default model (passed to CFN DefaultModel / bootstrap.sh --model).
# Packs that use AWS Bedrock get Bedrock model IDs; packs that use provider
# APIs (OpenAI, etc.) get provider-native model IDs. Without this mapping
# every pack inherits the template's Bedrock default, which breaks codex-cli
# (OpenAI rejects Bedrock ids with HTTP 400).
pack_default_model() {
case "$1" in
codex-cli) echo "gpt-5.4" ;;
openclaw|claude-code|kiro-cli) echo "us.anthropic.claude-opus-4-6-v1" ;;
nemoclaw) echo "us.anthropic.claude-opus-4-6-v1" ;;
hermes) echo "NousResearch/Hermes-3-Llama-3.1-8B" ;;
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use Bedrock model ID for Hermes default

The new Hermes branch returns NousResearch/Hermes-3-Llama-3.1-8B, but this value is propagated as the shared model field for dependency installs; deploy/bootstrap.sh writes one pack config for both deps and the target pack, then runs deps first, and packs/bedrockify/install.sh passes that model directly into bedrockify install-daemon --model (which is documented/defaulted as a Bedrock model ID). This means Hermes deployments can now configure bedrockify with a non-Bedrock model string, leading to failed startup or model-not-found errors when the proxy is used.

Useful? React with 👍 / 👎.

pi|ironclaw) echo "us.anthropic.claude-opus-4-6-v1" ;;
*) echo "us.anthropic.claude-opus-4-6-v1" ;;
esac
}

# Populate PARAM_VALUES from user config (call after collect_config)
build_deploy_params() {
PARAM_VALUES=(
"$ENV_NAME"
"$PACK_NAME"
"$PROFILE_NAME"
"$INSTANCE_TYPE"
"${DEFAULT_MODEL:-$(pack_default_model "$PACK_NAME")}"
"bedrock"
"$DEPLOY_REGION"
"$LOKI_WATERMARK"
Expand Down
13 changes: 13 additions & 0 deletions packs/codex-cli/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,19 @@ done
REGION="${PACK_ARG_REGION}"
MODEL="${PACK_ARG_MODEL}"

# ── Guard against Bedrock model IDs leaking in via CFN's DefaultModel ────────────────────────────────────
# install.sh / CFN template ship with a Bedrock-style DefaultModel
# (e.g. us.anthropic.claude-opus-4-6-v1) that's great for openclaw/claude-code
# but poison for codex-cli — OpenAI's API rejects it with HTTP 400.
# If the caller hands us a Bedrock-style ID, fall back to the pack default
# instead of writing a broken config.
CODEX_DEFAULT_MODEL="gpt-5.4"
if [[ "${MODEL}" =~ ^(us\.|eu\.|ap\.|anthropic\.|amazon\.|meta\.|mistral\.|cohere\.|ai21\.) ]]; then
warn "ignoring Bedrock-style model id '${MODEL}' — Codex CLI talks to OpenAI, not Bedrock"
warn "falling back to ${CODEX_DEFAULT_MODEL} (override with: bash install.sh --model <openai-model>)"
MODEL="${CODEX_DEFAULT_MODEL}"
fi

pack_banner "codex-cli"
log "region=${REGION} model=${MODEL} sandbox=danger-full-access approval=never"

Expand Down
Loading