fix(rename): only strip 'Loki-' prefix when hyphen separator present#30
Open
royosherove wants to merge 1 commit intomainfrom
Open
fix(rename): only strip 'Loki-' prefix when hyphen separator present#30royosherove wants to merge 1 commit intomainfrom
royosherove wants to merge 1 commit intomainfrom
Conversation
#29 broadened _account_already_prefixed to match any 'loki*' name (case-insensitive) to cover names like 'LOKI-Foo', but the first-install SSM write path still blindly did ${current_name:5} to derive the stored /loki/original-account-name. For names like 'loki1-MyAccount' or 'LokiDev-SomeAccount' that produced corrupt values ('-MyAccount', 'ev-SomeAccount'). Only strip when the lowercase 5-char prefix is exactly 'loki-'; otherwise fall back to ACCOUNT_ID, matching the existing fallback for empty results. Addresses Codex P2 on PR #29 (post-merge follow-up).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Codex P2 on #29 (post-merge follow-up): #29 (review)
#29 broadened
_account_already_prefixedto match any case-insensitiveloki*name, but the first-install SSM write path still blindly did${current_name:5}to derive/loki/original-account-name. For names likeloki1-MyAccountorLokiDev-SomeAccount, that produced corrupt values (-MyAccount,ev-SomeAccount).Only strip when the lowercase 5-char prefix is exactly
loki-; otherwise fall back toACCOUNT_ID, matching the existing empty-result fallback.