fix: wire roundhouse telegram params through all deploy paths#44
fix: wire roundhouse telegram params through all deploy paths#44royosherove merged 1 commit intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5cd4a9e679
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| echo -e " ${BOLD}Roundhouse requires a Telegram bot token.${NC}" | ||
| echo -e " Store it in AWS Secrets Manager and provide the secret id/arn." | ||
| echo "" | ||
| prompt "Secrets Manager id for Telegram bot token" TELEGRAM_BOT_TOKEN_SECRET "" |
There was a problem hiding this comment.
Avoid calling prompt here when -y/--non-interactive is set. prompt() only auto-fills in AUTO_YES mode when the default is non-empty, so this empty-default call still tries to open a TTY; in headless runs (CI/automation) roundhouse installs without explicit --telegram-* flags will hang or fail instead of returning a clear validation error.
Useful? React with 👍 / 👎.
prompt() only auto-fills when default is non-empty; the roundhouse TELEGRAM_BOT_TOKEN_SECRET / TELEGRAM_USER calls pass an empty default, so in headless runs (-y/--non-interactive) without the flags the installer would hang on a TTY read or fail with a confusing error. Add an explicit AUTO_YES guard before each prompt that fails with a clear message naming the required flag. Addresses Codex P1 on PR #44.
|
Addressed Codex review 4229191543 in 9a2c2ce: P1 \u2014 fail fast in AUTO_YES without telegram flags: AGREE, FIXED.
|
Codex review found that the roundhouse pack's required parameters (TelegramBotTokenSecret, TelegramUser) were not wired through: - Main installer (install.sh): interactive prompts + PARAM arrays - Terraform: variables.tf, main.tf template vars, userdata.sh.tpl - Registry: compatible_profiles restricted to builder (needs SM access) Also updates deploy/README.md with roundhouse in pack list.
royosherove
force-pushed
the
feat/roundhouse-pack-fixes
branch
from
9a2c2ce to
f479805
Compare
1 participant
Codex review found that the roundhouse pack's required parameters (TelegramBotTokenSecret, TelegramUser) were not wired through all deploy paths.
Changes
Follows up on commit 031eeca (feat: add roundhouse pack).