feat: welcome box with prerequisites + friendly credential errors#56
feat: welcome box with prerequisites + friendly credential errors#56royosherove merged 2 commits intomainfrom
Conversation
- Add show_welcome() with short intro box and 'Learn more' option - Show detailed prerequisites (AWS account, credentials, permissions) - Replace raw AWS CLI error with a helpful box suggesting fixes - Skip welcome in --non-interactive mode - Bump telemetron detect timeout from 30s to 45s (cold starts)
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42d87db9d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| echo "" | ||
|
|
||
| local choice | ||
| choice=$($GUM choose --header " Ready?" "Continue" "Learn more" "Quit" 2>/dev/null) || choice="Continue" |
There was a problem hiding this comment.
Use _gum_or_die (or explicit rc==130 handling) for this gum choose call: the current || choice="Continue" fallback converts every failure into an implicit continue, so pressing Ctrl-C at the welcome step no longer aborts and the installer proceeds into preflight/deploy flow. This regresses the script’s established interrupt behavior (_gum_or_die + cleanup_on_interrupt) and can surprise users who attempted to cancel before any AWS actions.
Useful? React with 👍 / 👎.
The welcome-box gum choose calls used '|| choice="Continue"' as the failure fallback, which converted Ctrl-C (gum exit 130) into a silent 'Continue' and proceeded into preflight/deploy. That regresses the installer's established interrupt behavior (_gum_or_die + cleanup_on_interrupt). Switch both gum choose invocations in show_welcome to _gum_or_die, which explicitly exits the installer on rc==130 and keeps the 'default to Continue on other failures (Escape, missing TTY)' behavior for the non-interrupt case. Addresses Codex P1 on PR #56.
|
Addressed Codex review 4239355880 in 622477d: P1 \u2014 preserve Ctrl-C abort in welcome prompt: AGREE, FIXED. |
1 participant
Adds a welcome screen when running the installer interactively:
--non-interactive/-ymodeCodex review requested.