Skip to content

fix: usability items #5, #6, #8 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
royosherove merged 1 commit into from
May 8, 2026
Merged

fix: usability items #5, #6, #8 #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ Multiple chat inputs (Telegram, Slack, Discord via [Vercel Chat SDK](https://cha

```bash
npm install -g @inceptionstack/roundhouse
roundhouse setup --telegram
roundhouse start # macOS (foreground) — Linux auto-starts via systemd
```

## Architecture
Expand Down
83 changes: 17 additions & 66 deletions src/cli/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,14 @@
*/

import { resolve, dirname } from "node:path";
import { readFile, writeFile, mkdir } from "node:fs/promises";
import { readFile } from "node:fs/promises";
import { readdirSync, statSync } from "node:fs";
import { execSync, execFileSync, spawn } from "node:child_process";
import { fileURLToPath } from "node:url";
import { performUpdate } from "../commands/update";

import {
CONFIG_DIR,
CONFIG_PATH,
ENV_FILE_PATH,
DEFAULT_CONFIG,
SESSIONS_DIR,
SERVICE_NAME,
fileExists,
Expand All @@ -24,17 +21,14 @@ import {
} from "../config";
import { getAgentSdkPackage } from "../agents/registry";
import { threadIdToDir } from "../util";
import { parseEnvFile, serializeEnvFile, envQuote, unquoteEnvValue } from "./env-file";
import { parseEnvFile, unquoteEnvValue } from "./env-file";
import {
SERVICE_PATH,
systemctl,
runSudo,
isServiceInstalled,
isServiceActive,
systemctlShow,
resolveExecStart,
generateUnit,
writeServiceUnit,
} from "./systemd";

const __filename = fileURLToPath(import.meta.url);
Expand Down Expand Up @@ -108,7 +102,11 @@ async function cmdRun() {
const tsxPath = resolve(__dirname, "..", "..", "node_modules", "tsx", "dist", "cli.mjs");
execFileSync(process.execPath, [tsxPath, indexPath], {
stdio: "inherit",
env: { ...process.env, ROUNDHOUSE_CONFIG: CONFIG_PATH },
env: {
...process.env,
ROUNDHOUSE_CONFIG: CONFIG_PATH,
NODE_NO_WARNINGS: "1", // Suppress npm deprecation spam
},
});
}
}
Expand All @@ -133,70 +131,23 @@ async function loadEnvFile(): Promise<void> {
}

async function cmdInstall() {
console.log("[roundhouse] 'install' is deprecated — use 'roundhouse setup --telegram' instead.\n");

if (process.platform === "darwin") {
console.log("[roundhouse] macOS detected — systemd is not available.\n");
console.log(" On macOS, use 'roundhouse start' to run in foreground,");
console.log(" or set up a launchd plist manually.\n");
console.log(" Tip: run 'roundhouse setup --telegram' to configure first.");
console.log(" On macOS:");
console.log(" 1. roundhouse setup --telegram");
console.log(" 2. roundhouse start\n");
process.exitCode = 1;
return;
}

console.log("[roundhouse] Installing as systemd daemon...\n");

await mkdir(CONFIG_DIR, { recursive: true });
if (await fileExists(CONFIG_PATH)) {
console.log(` Config exists: ${CONFIG_PATH}`);
} else {
await writeFile(CONFIG_PATH, JSON.stringify(DEFAULT_CONFIG, null, 2) + "\n");
console.log(` Created config: ${CONFIG_PATH}`);
console.log(` ⚠️ Edit this file to set allowedUsers and other settings.`);
}

// Write environment file for secrets — merge with existing to preserve manually-added keys
const ENV_KEYS = ["TELEGRAM_BOT_TOKEN", "ANTHROPIC_API_KEY", "OPENAI_API_KEY", "BOT_USERNAME", "ALLOWED_USERS", "NOTIFY_CHAT_IDS", "AWS_PROFILE", "AWS_DEFAULT_REGION", "AWS_ACCESS_KEY_ID", "AWS_SECRET_ACCESS_KEY", "AWS_SESSION_TOKEN"];
const resolvedEnvPath = await resolveEnvFilePath();
const existing = await fileExists(resolvedEnvPath)
? parseEnvFile(await readFile(resolvedEnvPath, "utf8"))
: new Map<string, string>();

// Override with current env vars for known keys
let envChanged = false;
for (const key of ENV_KEYS) {
if (process.env[key]) {
existing.set(key, envQuote(process.env[key]));
envChanged = true;
}
}
if (envChanged || !(await fileExists(ENV_FILE_PATH))) {
if (resolvedEnvPath !== ENV_FILE_PATH && await fileExists(resolvedEnvPath)) {
console.log(` Copying env file from ${resolvedEnvPath} to ${ENV_FILE_PATH}`);
}
await writeFile(ENV_FILE_PATH, serializeEnvFile(existing), { mode: 0o600 });
console.log(` Environment file: ${ENV_FILE_PATH}`);
}

// Generate and install systemd unit
const { execStart, nodeBinDir } = resolveExecStart();
const unit = generateUnit({ execStart, nodeBinDir });
await writeServiceUnit(unit);
systemctl("enable");
systemctl("start", "Daemon installed and started.");

console.log(`\n Config: ${CONFIG_PATH}`);
console.log(` Env file: ${ENV_FILE_PATH}`);
console.log(` Service: ${SERVICE_PATH}`);
console.log(` Logs: roundhouse logs`);
console.log(` Status: roundhouse status`);

if (!envChanged) {
console.log(`\n ⚠️ No env vars detected. Edit ${ENV_FILE_PATH} with your secrets:`);
console.log(` TELEGRAM_BOT_TOKEN=...`);
console.log(` Then add your API keys and run: roundhouse restart`);
}
console.log(" Recommended:");
console.log(" roundhouse setup --telegram\n");
console.log(" This sets up config, installs packages, pairs Telegram,");
console.log(" and installs the systemd service — all in one command.\n");
Comment on lines +144 to +147
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Make deprecated install fail or perform installation

On Linux, roundhouse install now only prints guidance and exits successfully without creating/updating the service, config, or env file. That creates a functional dead end for users and automation because the CLI still points people to install in other flows (start, status, update), but following that advice does nothing while returning exit code 0. Either delegate to setup or return a non-zero exit so callers don’t treat this as a successful install.

Useful? React with 👍 / 👎.

}

async function cmdUninstall() {

console.log("[roundhouse] Removing systemd daemon...");
try { systemctl("stop"); } catch {}
try { systemctl("disable"); } catch {}
Expand Down
12 changes: 11 additions & 1 deletion src/cli/setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ export function parseSetupArgs(argv: string[]): SetupOptions {
cwd: homedir(),
notifyChatIds: [],
systemd: platform() === "linux",
voice: true,
voice: platform() === "linux", // Default off on macOS (whisper install is heavy)
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve a way to enable voice on macOS setup

Changing the default to voice: platform() === "linux" makes macOS setup runs always set opts.voice to false, and there is no --voice flag to opt back in. Because setup later writes voice.stt.enabled=false whenever opts.voice === false, rerunning setup on macOS will forcibly disable STT even for users who previously enabled it, turning a “default off” change into an effective “always off” behavior.

Useful? React with 👍 / 👎.

psst: false,
nonInteractive: false,
force: false,
Expand Down Expand Up @@ -902,6 +902,16 @@ async function stepPostflight(): Promise<void> {
warn("ffmpeg not found (install for voice support)");
}

// Whisper STT check (only if voice is enabled)
if (platform() === "linux" || process.env.ROUNDHOUSE_VOICE === "1") {
if (!whichSync("whisper")) {
warn("whisper not found — STT will auto-install on first voice message");
log(" Pre-install: pip3 install openai-whisper");
} else {
ok("whisper available");
}
}

if (!process.env.TAVILY_API_KEY) {
warn("TAVILY_API_KEY not set — web search extension won't work");
log(" Get a free key at https://tavily.com and add to ~/.roundhouse/.env");
Expand Down
Loading