Switch to VSCode, Calva, deps.edn for easier getting started #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add VSCode + Calva as primary setup - Remove other additional setup instructions
|
@ghoseb Please be advised, the PR required fixes and cleanups. I will push those changes separately. |
|
@adityaathalye Sorry about that. I thought it was ready for merging. I looked at all the changes, I didn't see anything amiss. Apologies. |
|
No probs, they are small inconsistencies, easy to miss in the less than adequate Github PR review interface. I checked the diff locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had been meaning to make this simplification for a good while.
Thanks for pushing these changes, @kirankulkarni @0niket and @kapilreddy . I randomly noticed them today and have taken the liberty to create a PR, to keep the change observable from the in-clojure repo. Will review and merge at some point.