Schematic transform refactor #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milen-sage
reviewed
Nov 11, 2022
| class_object = dict() | ||
| class_object['@type'] = 'rdfs:Class' | ||
| class_object['@id'] = sdef.definition_uri | ||
| class_object['rdfs:label'] = sdef.name |
There was a problem hiding this comment.
I'm assuming here sdef.name is good enough since it's already CamelCased whereas the pascal_to_camel call at line 91 ensures the slot-to-property ends up being camelCased.
milen-sage
reviewed
Nov 11, 2022
| prefix_context[k] = v['prefix_reference'] | ||
| return prefix_context | ||
|
|
||
| def pascal_to_camel(word): |
There was a problem hiding this comment.
May want to rename from pascal_to_camel to snake_to_camel.
milen-sage
previously approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.