IP-stack horror: proper isolation between layers#1199
Merged
alfreb merged 23 commits intoincludeos:devfrom Feb 28, 2017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've now finally purged ethernet from higher level protocols. The main issue was to decide on how to hide / expose information in a packet as it traverses the stack. Essentially now ethernet is in charge of enforcing the isolation by hiding it's own header when pushing upstream, and revealing when it receives downstream. All headers above link-layer, including arp, will have their buffers start after the ethernet header. All packet-level protocols above IP still needs to know about the IP header so no need for further isolation there afaik.
Most of this work is done by changing the Packet class to have 3 data members, all pointers:
Lots of other fixes / changes here as well, notably an experimental packet wrapper in ICMPv4 - this is an alternative to inheriting IP-packet / Packet which can be useful if you need to temporarily add data members. Arp was also heavily modified. etc.
I expect issues and will fix.