Fix IPv4 address validation#1406
Merged
Conversation
|
Can one of the admins verify this patch with one of the following commands:
|
Contributor
|
ok to test |
| "(25[0–5]|2[0–4]\\d|[01]?\\d\\d?)\\." | ||
| "(25[0–5]|2[0–4]\\d|[01]?\\d\\d?)\\s*$" | ||
| #define OCTET_PATTERN "(25[0-5]|2[0-4]\\d|[01]?\\d\\d?)" | ||
| "^\\s*" OCTET_PATTERN "\\." OCTET_PATTERN "\\." OCTET_PATTERN "\\." OCTET_PATTERN "\\s*$", |
Contributor
There was a problem hiding this comment.
Is that a trailing comma(,) I'm seeing there?
Although it's calling the second constructor on this list, it's better off not being there...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regex had an en-dash instead of a hyphen in the character range