solo5: don't call timers::ready before initializing devices#1408
Merged
fwsGonzo merged 1 commit intoincludeos:devfrom Jul 25, 2017
Merged
solo5: don't call timers::ready before initializing devices#1408fwsGonzo merged 1 commit intoincludeos:devfrom
fwsGonzo merged 1 commit intoincludeos:devfrom
Conversation
|
Can one of the admins verify this patch with one of the following commands:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some apps like tcp-perf do their work inside
Service::readyinstead ofService::start, so they expect a network stack atready. Solo5 initialization currently callsTimers::initwhich callsService::readybefore initializing devices (inSolo5_manager::init). This change reorders that.