Skip to content

solo5: don't call timers::ready before initializing devices#1408

Merged
fwsGonzo merged 1 commit intoincludeos:devfrom
ricarkol:solo5-reorder-timers-ready
Jul 25, 2017
Merged

solo5: don't call timers::ready before initializing devices#1408
fwsGonzo merged 1 commit intoincludeos:devfrom
ricarkol:solo5-reorder-timers-ready

Conversation

@ricarkol
Copy link
Copy Markdown
Contributor

@ricarkol ricarkol commented Jul 25, 2017

Some apps like tcp-perf do their work inside Service::ready instead of Service::start, so they expect a network stack at ready. Solo5 initialization currently calls Timers::init which calls Service::ready before initializing devices (in Solo5_manager::init). This change reorders that.

@jenkins-includeos
Copy link
Copy Markdown

Can one of the admins verify this patch with one of the following commands:

  • "jenkins test please" for a one time test run
  • "ok to test" to accept latest and future commits on this pull request for testing
  • "add to whitelist" to add the author to the whitelist

@fwsGonzo fwsGonzo merged commit a2c91d0 into includeos:dev Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants