You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
added layout.txt using jinja2 to parse the build folder correctly
we can consider making multiple in the future.
using this code the following should work
Putting includeos into editable mode:
This is a bit of fiddling initially
Prepping the source
git clone git@github.com:hioa-cs/IncludeOS.git
cd IncludeOS
comment out the version in the conanfile.py #version = get_version()
(hopefully conan fixes that annoying issue)
Do some local adoptions to where your build folder is
edit layout.txt (jinja2 syntax) and set your build folder in the first line
{% set build_dir='build' %}
[bindirs]
cmake
[includedirs]
api
[libdirs]
{{ build_dir }}/plugins
{{ build_dir }}/drivers
{{ build_dir }}/lib
[resdirs]
{{ build_dir }}
set the conan package into editable mode
Make sure to adjust the version to whatever is apropriate (never than latest) conan editable add . includeos/0.15.0@includeos/test --layout=layout.txt
create a build folder and build includeos
Change this to whatever build folder matches the layout.txt
mkdir build
cd build
conan install .. -pr <conan_profile> (-o options like solo5=True etc)
cmake .. (-DTOOLCHAIN_PROFILE=xx.yy when needed)
make
Status
The package is now in editable mode and any dependencies should pick this package from your local cache. if you change anything to the code a simple make should be enough however if your dependencies change you need to redo the conan install step.
example on how it looks when its pulled into cache as editable includeos/0.15.0@includeos/test:45955af12a7f7608830c1d255b80a75440406e3c - Editable
finalizing the work / changes
Once the code is “finalized and if you want to verify that the conan package still builds
remove the editable conan editable remove includeos/0.15.0@includeos/test
remove the comment on the #version and do a normal conan create <source_path> includeos/test -pr <conan_profile>
Can the layout.txt live in the etc/ directory? I'm trying to clean up as much as possible in the root of the repo.
Also it looks like you are using conan 0.13.0 to run some of these commands. Might be worth mentioning. We might need to decide if we are moving to 0.13.0 for Jenkins as well. Conan releases seem to be very frequent right now.
Other than that this looks great. I'll test this tomorrow.
Can the layout.txt live in the etc/ directory? I'm trying to clean up as much as possible in the root of the repo.
Also it looks like you are using conan 0.13.0 to run some of these commands. Might be worth mentioning. We might need to decide if we are moving to 0.13.0 for Jenkins as well. Conan releases seem to be very frequent right now.
Other than that this looks great. I'll test this tomorrow.
Has this been tested? Are we going with conan release 1.13.1 ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added layout.txt using jinja2 to parse the build folder correctly
we can consider making multiple in the future.
using this code the following should work
Putting includeos into editable mode:
This is a bit of fiddling initially
Prepping the source
git clone git@github.com:hioa-cs/IncludeOS.git
cd IncludeOS
comment out the version in the
conanfile.py#version = get_version()(hopefully conan fixes that annoying issue)
Do some local adoptions to where your build folder is
edit
layout.txt(jinja2 syntax) and set your build folder in the first line{% set build_dir='build' %}
[bindirs]
cmake
[includedirs]
api
[libdirs]
{{ build_dir }}/plugins
{{ build_dir }}/drivers
{{ build_dir }}/lib
[resdirs]
{{ build_dir }}
set the conan package into editable mode
Make sure to adjust the version to whatever is apropriate (never than latest)
conan editable add . includeos/0.15.0@includeos/test --layout=layout.txtcreate a build folder and build includeos
Change this to whatever build folder matches the
layout.txtmkdir build
cd build
conan install .. -pr <conan_profile> (-o options like solo5=True etc)
cmake .. (-DTOOLCHAIN_PROFILE=xx.yy when needed)
make
Status
The package is now in editable mode and any dependencies should pick this package from your local cache. if you change anything to the code a simple make should be enough however if your dependencies change you need to redo the conan install step.
example on how it looks when its pulled into cache as editable includeos/0.15.0@includeos/test:45955af12a7f7608830c1d255b80a75440406e3c - Editable
finalizing the work / changes
Once the code is “finalized and if you want to verify that the conan package still builds
remove the editable
conan editable remove includeos/0.15.0@includeos/testremove the comment on the #version and do a normal
conan create <source_path> includeos/test -pr <conan_profile>