stop excluding files without an extension #2357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not clear why this was required in the first place, and it causes issues with tools such as `fd` or `rg` that parse .gitignore for exclusion/inclusion.
alfreb
approved these changes
Nov 8, 2025
Contributor
alfreb
left a comment
alfreb
left a comment
There was a problem hiding this comment.
Makes sense - could be as simple as someone in the past having checked in binaries by accident, more than once 😬
Contributor
Author
|
Yep. Probably something like that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only recognized
ripgrepwas excluding files because I knew it should have included some files that it gladly ignored. Since they showed up ingrep -rnI had to bisect the issue.It is not clear why this was required in the first place, and the commit (312b199) doesn't really explain why. Since it causes issues with tools such as
fdorrgthat parse.gitignorefor exclusion/inclusion, we might as well revert it.One could argue these tools should look at
git ls-filesinstead of only.gitignore, but unless we have a reason to ignore all files without an extension this seems like a more natural choice to avoid any issues: we have 75 files in our project without an extension, and creating new files won't show up ingit statusorgit diffeither.