Adds missing exit value checks in install script#848
Merged
fwsGonzo merged 1 commit intoincludeos:devfrom Oct 6, 2016
gurka:dev
Merged
Adds missing exit value checks in install script#848fwsGonzo merged 1 commit intoincludeos:devfrom gurka:dev
fwsGonzo merged 1 commit intoincludeos:devfrom
gurka:dev
Conversation
|
Can one of the admins verify this patch with one of the following commands:
|
Contributor
|
Yeah, sudo should not be used with install.sh - because of the reason you state; everything gets build and installed as root. Thanks for the PR :) ok to test |
Contributor
|
retest please |
Contributor
|
This looks great. Having it exit at the point of failure will make it a lot easier to identify the error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So this is basically just some additional return / exit value checks in the install scripts to make it more robust. I found most of these problems when trying to install IncludeOS under Debian stable. Most of the build steps failed but the script kept going, and finally outputted "Done! Test your installation with ./test.sh", which was kind of .. not so good. This commit partially solves #620 .
I removed the "sudo" part from the README since the script will use sudo when needed. Using sudo when executing install.sh will also build and install everything as root:root and that is probably not want most users want.
I'm not sure if the check for "sudo" is necessary since all supported systems have sudo installer per default (?). Debian does however not, and that's why I added it.