Skip to content

kernel: draft of cpuid rewrite#861

Merged
fwsGonzo merged 1 commit intoincludeos:devfrom
gurka:cpuid
Oct 9, 2016
Merged

kernel: draft of cpuid rewrite#861
fwsGonzo merged 1 commit intoincludeos:devfrom
gurka:cpuid

Conversation

@gurka
Copy link
Copy Markdown
Contributor

@gurka gurka commented Oct 8, 2016

First draft of cpuid rewrite. Open questions:

  • Is the cache necessary? I did some research and found that cpuid is a pretty expensive call, but maybe the overhead of the cache makes it useless.
  • Maybe add vendor information to each FeatureInfo since not all features are applicable to both Intel and AMD CPUs. At the moment the user needs to first check isIntelCpu or isAmdCpu before asking for a specific feature (if the feature is not applicable to both).

@jenkins-includeos
Copy link
Copy Markdown

Can one of the admins verify this patch with one of the following commands:

  • "test please" for a one time test run
  • "ok to test" to accept latest and future commits on this pull request for testing
  • "add to whitelist" to add the author to the whitelist

@fwsGonzo
Copy link
Copy Markdown
Member

fwsGonzo commented Oct 8, 2016

Looks really nice :) Now we just need the kvm paravirtual stuff, from here: https://www.kernel.org/doc/Documentation/virtual/kvm/cpuid.txt

I tried making PV_EOI work, but it's not setting the bit for me. I suspect we have to check the feature first maybe. Or maybe it's just not enabled

NOTE: function: define KVM_CPUID_FEATURES (0x40000001) <-- IS A LIE
you have to explicitly check EAX for the location oif the kvm cpu features

@fwsGonzo
Copy link
Copy Markdown
Member

fwsGonzo commented Oct 8, 2016

ok to test

@fwsGonzo fwsGonzo merged commit 04ca28a into includeos:dev Oct 9, 2016
@gurka gurka deleted the cpuid branch October 16, 2016 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants