Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds flake support to vmrunner, which will allow includeos/IncludeOS to implement their own flake natively.
Because
bootitself is reliant on the chainloader being on path, and we can't know this until after a unikernel is built, we provide amkBootfunction which exposes theINCLUDEOS_CHAINLOADERvariable to vmrunner. With this, we can exposeboot-unikernelas a chainload-ready booter from the unikernel's side.This doesn't change anything for non-flake users.
Minor:
/resultto gitignore: this is the default output directory of nix.default.nix(with flakes, these are actually necessary).